Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete fix of CVE-2019-13238, Exhaustive memory misunhandle #803

Open
5hadowblad3 opened this issue Oct 19, 2022 · 0 comments
Open

Incomplete fix of CVE-2019-13238, Exhaustive memory misunhandle #803

5hadowblad3 opened this issue Oct 19, 2022 · 0 comments

Comments

@5hadowblad3
Copy link

A memory allocation failure unhandled in Ap4RtpAtom.cpp and leads to crashes. This seems to be an incomplete fix of issue #396, CVE-2019-13238.

./mp42aac input_file /dev/null

In file Source/C++/Core/Ap4RtpAtom.cpp
image
AP4_RtpAtom allocate a new buffer to parse the atom in the stream.
The unhandled memory allocation failure cause the read content memcpy to a null pointer.

The rest of issue seems be similar with previous issue.

Asan trace report:

==725001==WARNING: AddressSanitizer failed to allocate 0xffffffffff00025b bytes
=================================================================
==725001==ERROR: AddressSanitizer: allocator is out of memory trying to allocate 0xffffffffff00025b bytes
    #0 0x4f7fb7 in operator new[](unsigned long)  /dependence/llvm11/llvm-11.0.0.src/projects/compiler-rt/lib/asan/asan_new_delete.cpp:102:3
    #1 0x652e4a in AP4_RtpAtom::AP4_RtpAtom(unsigned int, AP4_ByteStream&)  /benchmark/Bento4/Source/C++/Core/Ap4RtpAtom.cpp:50:25

==725001==HINT: if you don't care about these errors you may set allocator_may_return_null=1
SUMMARY: AddressSanitizer: out-of-memory  /dependence/llvm11/llvm-11.0.0.src/projects/compiler-rt/lib/asan/asan_new_delete.cpp:102:3 in operator new[](unsigned long)
==725001==ABORTING

mp42aac_exhaustive_AP4_RtpAtom50.zip
(unzip first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant