Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Support in Node #12

Closed
jimthedev opened this issue Sep 21, 2014 · 6 comments

Comments

@jimthedev
Copy link

commented Sep 21, 2014

Hi,

Awesome job on axios. One question I have is, is https compatibility in Node something that you would consider for this package? Currently, it looks like there is just an http adapter. Would you consider https and if so, would you consider a flag to ignore self signed ssl certs?

Thanks much!

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Sep 21, 2014

@jimthedev https support for node.js is planned for 0.4.0 release. I will have to do some research on self signed certs. Seems like a valid option.

@jimthedev

This comment has been minimized.

Copy link
Author

commented Sep 21, 2014

@mzabriskie Awesome! Currently, as a workaround I just swapped out http for https in the adapter and set this rejectUnauthorized: false

Not safe, but I am only working in dev so it suits my needs.

mzabriskie added a commit that referenced this issue Sep 21, 2014

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Sep 22, 2014

@jimthedev I have added SSL support. I am not going to provide a flag for self signed certs. You can get around it by doing:

process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';

@mzabriskie mzabriskie closed this Sep 22, 2014

@jimthedev

This comment has been minimized.

Copy link
Author

commented Sep 22, 2014

Cool. Thanks a bunch. What tag is this coming in on? 0.4.0? Currently looks like 0.3.1 is still the latest. Is this correct?

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Sep 22, 2014

@jimthedev current is 0.3.1, SSL support will be on 0.4.0. I have a couple open issues that I will address before the next release. Probably by the end of the week.

@jimthedev

This comment has been minimized.

Copy link
Author

commented Sep 22, 2014

@mzabriskie Great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.