New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios rejects on the successful request (204) in IE9 #201

Closed
savantaparna opened this Issue Jan 22, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@savantaparna

savantaparna commented Jan 22, 2016

Current behavior:

Axios rejects the promise on successful request in IE9 on status code 204.

Expected behavior:

Axios should resolve the promise when it receives status code as 204 in IE9.

I have found the discussion of this same issue -
http://stackoverflow.com/questions/10046972/msie-returns-status-code-of-1223-for-ajax-request

IE coerces 204 to 1223 and this falls out range of success codes (>= 200 && < 300).

savantaparna pushed a commit to savantaparna/axios that referenced this issue Jan 22, 2016

@mzabriskie

This comment has been minimized.

Member

mzabriskie commented Jan 22, 2016

Wouldn't expect anything less from IE :/

mzabriskie added a commit that referenced this issue Jan 22, 2016

Merge pull request #202 from savantaparna/master
Fixing #201 by treating status code 1223 as a success code.

@mzabriskie mzabriskie closed this Jan 22, 2016

@mzabriskie

This comment has been minimized.

Member

mzabriskie commented Jan 24, 2016

This fix is available in 0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment