Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ArrayBuffer and related views as data #10

Merged
merged 1 commit into from Sep 18, 2014

Conversation

@mathbruyen
Copy link

commented Sep 18, 2014

In order to push binary data under the form of ArrayBuffer and its related views (Int8Array, ...) one needs not to stringify those.

For the XHR adapter there is nothing to do as it natively supports ArrayBuffer view in req.send().

Node's http adapter supports only string or Buffer thus a transformation to Buffer is required before setting content length header.

Mathieu Bruyen
Allow ArrayBuffer and related views as data
In order to push binary data under the form of ArrayBuffer and
its related views (Int8Array, ...) one needs not to stringify
those.

For the XHR adapter there is nothing to do as it natively supports
ArrayBuffer in req.send().

Node's http adapter supports only string or Buffer thus a
transformation to Buffer is required before setting content length
header.

mzabriskie added a commit that referenced this pull request Sep 18, 2014

Merge pull request #10 from mathbruyen/arraybuffer
Allow ArrayBuffer and related views as data

@mzabriskie mzabriskie merged commit c03e51c into axios:master Sep 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@mzabriskie

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

@mathbruyen thank you for the pull requests!

@mathbruyen mathbruyen deleted the mathbruyen:arraybuffer branch Sep 18, 2014

@mathbruyen

This comment has been minimized.

Copy link
Author

commented Sep 18, 2014

You're welcome, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.