fix: replace ternary side effect with if/else and fix null Authorizat…

[azandabot]

Summary

Two issues found in scripts/axios-build-instance.js:

1. Ternary used for side effects
   The contributing guidelines reference the node-style-guide which discourages using ternary operators purely for side effects with no return value. Replaced with an if/else for clarity.

2. Null Authorization header
   When GITHUB_TOKEN is undefined, the header was being set to null rather than being omitted entirely. Setting a header to null can result in the string "null" being sent in some environments. Fixed using conditional object spreading so the header is simply absent when no token is provided.

Note: npm run test shows 1049/1050 tests passing. The single unhandled error is a webkit browser session timeout unrelated to this change.

---

Summary by cubic

Fixes the GitHub axios client to omit the Authorization header when GITHUB_TOKEN is missing and replaces a ternary side effect with a clear if/else. Prevents sending a "null" header; behavior is unchanged when a token is provided.

Changes

• In scripts/axios-build-instance.js, replace ternary side effect with if/else for logging.
• Only set Authorization when GITHUB_TOKEN exists using conditional object spread.
• Synced with latest v1.x (no functional changes).

Notes

• Docs: Update /docs/ to clarify the header is added only when a token is set.
• Testing: No tests added; add cases to assert header presence/absence and log paths.
• Semantic version impact: Patch.

^{Written for commit b525733. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Confidence score: 4/5

• This PR is likely safe to merge, with only a moderate-risk behavior change noted (severity 5/10, confidence 7/10).
• In scripts/axios-build-instance.js, conditionally omitting Authorization may stop explicitly clearing inherited default headers, which can lead to unintended auth headers being sent in some request paths.
• The impact appears scoped to header-construction behavior rather than a broad functional break, so risk looks manageable with a focused verification pass.
• Pay close attention to scripts/axios-build-instance.js - ensure Authorization is explicitly unset when required to avoid inherited default header leakage.

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[jasonsaayman]

Just a couple changes before this one can land.

[azandabot]

Done, both changes applied. Thanks for the review!

All threads resolved