Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support third-party library to serialize url params #121

Merged
merged 1 commit into from Oct 27, 2015

Conversation

@dfournier
Copy link
Contributor

commented Oct 3, 2015

Because servers don't parse url params the same way, an optional third-party could be use. To do so, paramsSerializer can be provided in the configuration. It's a function which takes params as arguments and returns encoding params.

This pull request is related to #101.

@dfournier dfournier force-pushed the azendoo:custom-encode-params-method branch 3 times, most recently from b20ca21 to 6893d40 Oct 3, 2015

@dfournier

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2015

@mzabriskie so do you think it's a better solution than #101? I think so 😸

@dfournier

This comment has been minimized.

Copy link
Contributor Author

commented Oct 27, 2015

@mzabriskie are you still busy? Is the PR could be merged or should I a custom version on my project? 😿

@dfournier dfournier force-pushed the azendoo:custom-encode-params-method branch from 6893d40 to 14ede9e Oct 27, 2015

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Oct 27, 2015

Sorry! Yes, I like this better too. Thanks for the help!

mzabriskie added a commit that referenced this pull request Oct 27, 2015

Merge pull request #121 from azendoo/custom-encode-params-method
Add support third-party library to serialize url params

@mzabriskie mzabriskie merged commit 11c12b2 into axios:master Oct 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dfournier

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2015

You're welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.