Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getUri signature to TypeScript definition. #1736

Merged
merged 3 commits into from Aug 21, 2018
Merged

Add getUri signature to TypeScript definition. #1736

merged 3 commits into from Aug 21, 2018

Conversation

@atrauzzi
Copy link
Contributor

@atrauzzi atrauzzi commented Aug 17, 2018

This is in support of #1624. It adds a definition for the getUri feature added by @delirius325 to the base axios type.

index.d.ts Outdated
@@ -127,6 +127,7 @@ export interface AxiosInstance {
request: AxiosInterceptorManager<AxiosRequestConfig>;
response: AxiosInterceptorManager<AxiosResponse>;
};
getUri(config: AxiosRequestConfig): string;
Copy link
Member

@emilyemorehouse emilyemorehouse Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config should be optional (it falls back to only using the default settings)

Loading

@emilyemorehouse
Copy link
Member

@emilyemorehouse emilyemorehouse commented Aug 21, 2018

Thank you @atrauzzi! There's just the small update needed (see my comment) and I'll merge this.

Loading

@emilyemorehouse emilyemorehouse self-assigned this Aug 21, 2018
@atrauzzi
Copy link
Contributor Author

@atrauzzi atrauzzi commented Aug 21, 2018

Woops! I should have known that... 😄

Alright, change made!

Loading

@emilyemorehouse emilyemorehouse merged commit 7db0494 into axios:master Aug 21, 2018
1 check passed
Loading
@atrauzzi atrauzzi deleted the add-get-uri-definition branch Aug 21, 2018
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants