Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `getUri` signature to TypeScript definition. #1736

merged 3 commits into from Aug 21, 2018


Copy link

atrauzzi commented Aug 17, 2018

This is in support of #1624. It adds a definition for the getUri feature added by @delirius325 to the base axios type.

This is in support of #1624.
index.d.ts Outdated
@@ -127,6 +127,7 @@ export interface AxiosInstance {
request: AxiosInterceptorManager<AxiosRequestConfig>;
response: AxiosInterceptorManager<AxiosResponse>;
getUri(config: AxiosRequestConfig): string;

This comment has been minimized.

Copy link

emilyemorehouse Aug 21, 2018


config should be optional (it falls back to only using the default settings)


This comment has been minimized.

Copy link

emilyemorehouse commented Aug 21, 2018

Thank you @atrauzzi! There's just the small update needed (see my comment) and I'll merge this.

@emilyemorehouse emilyemorehouse self-assigned this Aug 21, 2018

This comment has been minimized.

Copy link
Contributor Author

atrauzzi commented Aug 21, 2018

Woops! I should have known that... 😄

Alright, change made!

@emilyemorehouse emilyemorehouse merged commit 7db0494 into axios:master Aug 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@atrauzzi atrauzzi deleted the atrauzzi:add-get-uri-definition branch Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.