Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes axios error generic to use axios response #1738

Merged
merged 4 commits into from May 7, 2019

Conversation

@sumanla13a
Copy link
Contributor

@sumanla13a sumanla13a commented Aug 17, 2018

Regarding #1730

Adjusts index.d.ts so that it takes type argument which is passed on to AxiosResponse.

export interface AxiosError<T = any> extends Error {
  config: AxiosRequestConfig;
  code?: string;
  request?: any;
  response?: AxiosResponse<T>;
}
@JakeSidSmith
Copy link

@JakeSidSmith JakeSidSmith commented Sep 6, 2018

Really need this feature. Was about to open a PR myself. Would be great to get it merged. 🙂

Loading

@sumanTitan
Copy link

@sumanTitan sumanTitan commented Sep 13, 2018

Can this be merged if this is all right?

Loading

crvN
crvN approved these changes Nov 8, 2018
crvN
crvN approved these changes Nov 8, 2018
@emilyemorehouse emilyemorehouse merged commit 047501f into axios:master May 7, 2019
1 check passed
Loading
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants