Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing .eslintrc without extension #1789

Merged
merged 2 commits into from Sep 17, 2018
Merged

Conversation

@ManoelLobo
Copy link
Contributor

@ManoelLobo ManoelLobo commented Sep 13, 2018

Summary

.eslintrc without extension is deprecated (https://eslint.org/docs/user-guide/configuring#configuration-file-formats).

Fix #1788

Changes

  • Change the content of .eslintrc to be a js module (module.exports)
  • Add .js extension to .eslintrc
Copy link
Collaborator

@rootsher rootsher left a comment

agrees 👍 )

Loading

@rootsher rootsher merged commit 81f0d28 into axios:master Sep 17, 2018
1 check passed
Loading
@ManoelLobo ManoelLobo deleted the pr/eslintrc-extension branch Dec 7, 2018
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants