Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle timeout on XHR requests #227

Merged
merged 2 commits into from Mar 3, 2016

Conversation

Projects
None yet
@rogeriochaves
Copy link
Contributor

rogeriochaves commented Feb 5, 2016

Rejects the promise when a XHR timeout happens, solving issue #226

@tquetano-r7

This comment has been minimized.

Copy link

tquetano-r7 commented Feb 16, 2016

Totally solves #236

@rogeriochaves

This comment has been minimized.

Copy link
Contributor Author

rogeriochaves commented Feb 17, 2016

any chances of getting this in soon?

@nettofarah

This comment has been minimized.

Copy link
Contributor

nettofarah commented Feb 18, 2016

What about node.js timeouts?
it would probably make sense to add some tests to this code path too.

@mzabriskie

This comment has been minimized.

Copy link
Member

mzabriskie commented Feb 24, 2016

@rogeriochaves please change this to be more in line with the http adapter https://github.com/mzabriskie/axios/blob/master/lib/adapters/http.js#L121-L125

@rogeriochaves

This comment has been minimized.

Copy link
Contributor Author

rogeriochaves commented Mar 2, 2016

mzabriskie added a commit that referenced this pull request Mar 3, 2016

Merge pull request #227 from rogeriochaves/master
Handle timeout on XHR requests

@mzabriskie mzabriskie merged commit 32080df into axios:master Mar 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mzabriskie

This comment has been minimized.

Copy link
Member

mzabriskie commented Mar 3, 2016

Thanks for the PR!

@tquetano-r7

This comment has been minimized.

Copy link

tquetano-r7 commented Mar 6, 2016

@mzabriskie, I've seen this (and several other changes) has been merged into master, however the NPM version has not changed so the rewards cannot be reaped via NPM. Would you mind bumping the version?

@incubus8

This comment has been minimized.

Copy link

incubus8 commented Mar 6, 2016

Hi @mzabriskie @rogeriochaves , is the patch also handle net::ERR_INTERNET_DISCONNECTED when the client internet suddenly went offline?

@mzabriskie

This comment has been minimized.

Copy link
Member

mzabriskie commented Mar 6, 2016

@tquetano-r7 I am working on getting tests running on Saucelabs for all supported browsers. As soon as that's done I'll release a new version on npm.

@mzabriskie

This comment has been minimized.

Copy link
Member

mzabriskie commented Mar 6, 2016

@incubus8 I will try that out. I suspect this patch won't address that, but the onerror handler should.

@adanperez

This comment has been minimized.

Copy link

adanperez commented Mar 18, 2016

Hi @mzabriskie is there an ETA for this to be released? thanks!

@adrianhyde adrianhyde referenced this pull request Apr 5, 2016

Closed

Planning for 1.0 #206

7 of 8 tasks complete
@sathishkumarsoundharajan

This comment has been minimized.

Copy link

sathishkumarsoundharajan commented Apr 7, 2016

Hi does this issue fix has been realsed to npm ? i am facing #236.

@sathishkumarsoundharajan

This comment has been minimized.

Copy link

sathishkumarsoundharajan commented Apr 13, 2016

Any Update please ?

@mikechabot

This comment has been minimized.

Copy link

mikechabot commented Apr 14, 2016

+1. hacking the patch in prod !== fun

@mzabriskie

This comment has been minimized.

Copy link
Member

mzabriskie commented Apr 22, 2016

Version 0.10.0 includes this PR.

@ACCTFORGH

This comment has been minimized.

Copy link

ACCTFORGH commented May 9, 2016

I tried 0.10.0 and 0.11.0 in React Native 0.24 but still the code in catch does not run after timeout. The way I tested was I turned off the laptop wifi while left the Genymotion emulator WIFI on. In this way, the app would think there was internet so axios would still send the network request but would for sure not get any response. Any ideas on this?

@L3V147H4N

This comment has been minimized.

Copy link

L3V147H4N commented Jul 14, 2016

@mcs07 Im using version 0.13.0 and react native 0.24.1 and still doesnt work

@nishantpardamwar

This comment has been minimized.

Copy link

nishantpardamwar commented Jan 9, 2017

I'm using version 0.15.3 and react native 0.40.0 and still doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.