Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with gitpod #2637

Merged
merged 2 commits into from Feb 17, 2021
Merged

Integrate with gitpod #2637

merged 2 commits into from Feb 17, 2021

Conversation

nisarhassan12
Copy link
Contributor

@nisarhassan12 nisarhassan12 commented Jan 3, 2020

Hi! there 馃檪

This PR simplifies code contributions by fully automating the dev setup with Gitpod (a free online VS Code-like IDE) for contributing. With a single click, it'll launch a workspace and automatically:

  • clone the axios repo.
  • install the dependencies.
  • run npm start.

So that anyone interested in contributing can start straight away.

You can give it a try on My Fork of the repo:

https://gitpod.io/#https://github.com/nisarhassan12/axios/

image

@nisarhassan12 nisarhassan12 changed the title adding gitpod to simplify code contributions & automate the dev setup. simplifies code contributions & automates the dev setup. #2755 Jan 3, 2020
@chinesedfan chinesedfan changed the title simplifies code contributions & automates the dev setup. #2755 Integrate with gitpod Feb 16, 2020
@nisarhassan12 nisarhassan12 force-pushed the master branch 2 times, most recently from 4a29aaf to 34e1ac3 Compare Mar 19, 2020
@nisarhassan12
Copy link
Contributor Author

@nisarhassan12 nisarhassan12 commented Mar 19, 2020

Rebased on top of latest master.

@jasonsaayman jasonsaayman added the status:work in progress label Jun 22, 2020
@chinesedfan chinesedfan removed the status:work in progress label Aug 29, 2020
@nisarhassan12
Copy link
Contributor Author

@nisarhassan12 nisarhassan12 commented Nov 16, 2020

Rebased on top of the latest master @mzabriskie @nickuraltsev

@jasonsaayman
Copy link
Member

@jasonsaayman jasonsaayman commented Nov 19, 2020

@chinesedfan @timemachine3030 What do you guys think would be helpful?

Copy link
Collaborator

@chinesedfan chinesedfan left a comment

#1958 has already mentioned GitPod. I can accept a tiny change to move the link from examples/README.md to the main README.md.

@nisarhassan12
Copy link
Contributor Author

@nisarhassan12 nisarhassan12 commented Nov 23, 2020

Thanks, @chinesedfan Sounds good.

@jasonsaayman
Copy link
Member

@jasonsaayman jasonsaayman commented Feb 4, 2021

@ nisarhassan12 will you be making these changes soon? I will so long tag this for you into the next proposed release.

@nisarhassan12
Copy link
Contributor Author

@nisarhassan12 nisarhassan12 commented Feb 5, 2021

@jasonsaayman Thanks. I have made the requested change with a slight modifcation.

@jasonsaayman jasonsaayman merged commit 535d0c4 into axios:master Feb 17, 2021
1 check passed
@jasonsaayman jasonsaayman moved this from To do to Done in v0.22.0 Mar 17, 2021
mbargiel pushed a commit to mbargiel/axios that referenced this issue Jan 27, 2022
鈥ion. (axios#2637)

Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.22.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants