Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nodejs http.request option: insecureHTTPParser for interoperability #2930

Merged
merged 2 commits into from Sep 5, 2021

Conversation

@fabiel-leon
Copy link
Contributor

@fabiel-leon fabiel-leon commented Apr 26, 2020

February 2020 Security Releases
by Sam Roberts, 2020-02-06 Nodejs has increase the strictness of HTTP header parsing. There are no known vulnerabilities addressed, but lax HTTP parsing has historically been a source of problems. Some commonly used sites are known to generate invalid HTTP headers, a --insecure-http-parser CLI option or insecureHTTPParser http option can be used if necessary for interoperability, but is not recommended.
https://nodejs.org/en/blog/vulnerability/february-2020-security-releases/#strict-http-header-parsing-none

Bug Error: Parse Error: Invalid header value char

adding the new option for nodejs http.request: insecureHTTPParser for interoperability

see nodejs http.request options docs

see nodejs/node#27711

@chinesedfan
Copy link
Collaborator

@chinesedfan chinesedfan commented Apr 26, 2020

Added to #2808.

Loading

@github-actions
Copy link

@github-actions github-actions bot commented Jun 22, 2020

Hello! 👋 \n\nThis pull request is being automatically marked as stale because it has not been updated in a while. Please confirm that the issue is still present and reproducible. If no updates or new comments are received the pull request will be closed in a few days. \n\nThanks

Loading

@queso
Copy link

@queso queso commented Sep 14, 2021

It seems the new boolean value was missed in the request config type interface

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants