Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete fails in IE8/IE9, the verb needs to be capitalized. #30

Merged
merged 2 commits into from Dec 10, 2014

Conversation

@torarnek
Copy link
Contributor

commented Dec 10, 2014

I discovered this while testing in IE8/IE9. The ActiveXObject object sends the request with the verb in lower case letters, and fails. The verb should always be in capital letters.

@torarnek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 10, 2014

I am eager to start using axios, however I need this PR merged / issue fixed, so I am hoping for minor release asap. ;)

mzabriskie added a commit that referenced this pull request Dec 10, 2014

Merge pull request #30 from torarnek/master
Fixing errors caused by lowercase verb

@mzabriskie mzabriskie merged commit 32ca449 into axios:master Dec 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@mzabriskie

This comment has been minimized.

Copy link
Member

commented Dec 10, 2014

@torarnek thanks for the PR. I will release this evening.

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Dec 11, 2014

This is available with version 0.4.2

@torarnek

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2014

Excellent, thank you!

On Thu, Dec 11, 2014 at 8:18 AM, Matt Zabriskie notifications@github.com
wrote:

This is available with version 0.4.2


Reply to this email directly or view it on GitHub
#30 (comment).

Tor Arne

2rist pushed a commit to 2rist/mappersmith that referenced this pull request Dec 18, 2017

Igor Slutskii
method name should be uppercase
E.g. see an issue and a fix in axios
axios/axios#26
axios/axios#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.