Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for URLSearchParams #317

Merged
merged 2 commits into from May 25, 2016

Conversation

@nickuraltsev
Copy link
Member

commented May 7, 2016

Related to #97

@coveralls

This comment has been minimized.

Copy link

commented May 7, 2016

Coverage Status

Coverage increased (+0.3%) to 91.573% when pulling f20490e on nickuraltsev:urlsearchparams into 580ef52 on mzabriskie:master.

@nickuraltsev

This comment has been minimized.

Copy link
Member Author

commented May 16, 2016

I've just realized that isURLSearchParams will return true for some other built-in objects with similar API like FormData. Can we do the following instead?

typeof URLSearchParams !== 'undefined' && value instanceof URLSearchParams

URLSearchParams must be in the global scope to make it work.

@coveralls

This comment has been minimized.

Copy link

commented May 19, 2016

Coverage Status

Coverage increased (+0.4%) to 91.62% when pulling 2b8d89a on nickuraltsev:urlsearchparams into 580ef52 on mzabriskie:master.

@mzabriskie mzabriskie merged commit 112f98d into axios:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.