Fixing an issue that type 'null' and 'undefined' is not assignable to validateStatus when typescript strict option is enabled #3200
+9
−1
Conversation
Thanks for your update. And in order to avoid similar mistakes, can you update the test file with a new case? In addition, |
@cprayer Ping for updating. |
… validateStatus when typescript strict option is enabled
@chinesedfan Before -> validateStatus?: ((status: number) => boolean | null)
After - validateStatus?: ((status: number) => boolean) | null
TS2345 Error of line 341, 345 is irrelevant to the validateStatus option. So I don't care about this. |
This seems to be a good solution to this issue. |
This was referenced Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In previous my PR(#2773), I had missed about two things.
So I fix above things in this PR.