You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@timemachine3030 thanks for the pull request, don't know why that test was skipped. By the way, your code review on axios is awesome, a great read! @chinesedfan maybe you know why this test was set to skip? If not let's add it back.
Looking at the CI builds I'm guessing that there is some tear down/cleanup missing from the socket test that is causing havoc. They don't fail in the same place nor is the failure consistent between versions (I don't think that it is a version number thing, I think that it is a timing issue). I'll try to reproduce here.
I was able to reproduce a failure on Windows 7: node -v: 10.0.0
1) supports http with nodejs
should support sockets:
Uncaught Error: listen EACCES ./test.sock
at Server.setupListenHandle [as _listen2] (net.js:1313:19)
at listenInCluster (net.js:1378:12)
at Server.listen (net.js:1477:5)
at Context.<anonymous> (test\unit\adapters\http.js:376:8)
at process.topLevelDomainCallback (domain.js:121:23)
@chinesedfan To answer your question on collaboration: Yes. I'm game for helping out. As a mention in the review, my company uses the package. They are willing to donate some of my development time to open source software.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.