Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different socket for Win32 test #3375

Merged

Conversation

Pilot and others added 7 commits Oct 25, 2020
Co-authored-by: Xianming Zhong <chinesedfan@qq.com>
…3030/axios into cleanup/remove-test-skipping
@timemachine3030
Copy link
Contributor Author

@timemachine3030 timemachine3030 commented Nov 1, 2020

Not sure how this would specifically resolve the error in #3364 and I do not have a sauce key.

I tried testing Chrome 86, Win7, Node.js 10.0.0 multiple time with no error. Will try the Win10 failures when my VM finishes (tomorrow).

@timemachine3030 timemachine3030 marked this pull request as ready for review Nov 14, 2020
@timemachine3030 timemachine3030 changed the title WIP: Use different socket for Win32 test Use different socket for Win32 test Nov 14, 2020
@chinesedfan
Copy link
Collaborator

@chinesedfan chinesedfan commented Nov 22, 2020

Now the CI works well. If it is stable enough, we can ignore.

@timemachine3030
Copy link
Contributor Author

@timemachine3030 timemachine3030 commented Nov 24, 2020

This is still worth merging. Any developer on Windows, running the tests, will get an error.

@jasonsaayman
Copy link
Collaborator

@jasonsaayman jasonsaayman commented Nov 24, 2020

I think this is a good idea to have it merged, there is a large user base on Windows and this could potentially keep people from contributing in the future and we don't want that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v0.21.1
Awaiting triage
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants