Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and cleanup of transformResponse #3377

Merged
merged 5 commits into from Mar 24, 2021

Conversation

@timemachine3030
Copy link
Contributor

@timemachine3030 timemachine3030 commented Nov 1, 2020

Fixes #3374, including my own cleanup.

  • Tests for transformResponse
  • Remove eslint error by renaming the var
  • Test the data a length to avoid JSON.parse headache
  • Use util.isString() over typeof
timemachine3030 and others added 2 commits Nov 1, 2020
 - Tests for transformResponse
 - Remove eslint error by renaming the var
 - Test that there data a length to avoid JSON.parse headache
 - Use `util.isString()` over `typeof`
@jasonsaayman jasonsaayman self-assigned this Dec 9, 2020
@jasonsaayman jasonsaayman added this to the v0.21.1 milestone Dec 9, 2020
@jasonsaayman jasonsaayman removed this from the v0.21.1 milestone Dec 9, 2020
@jasonsaayman jasonsaayman added this to the v0.22.0 milestone Dec 9, 2020
@jasonsaayman jasonsaayman added this to To do in v0.22.0 Feb 16, 2021
Copy link
Member

@jasonsaayman jasonsaayman left a comment

This looks good

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.22.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

2 participants