Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and cleanup of transformResponse #3377

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

timemachine3030
Copy link
Contributor

Fixes #3374, including my own cleanup.

  • Tests for transformResponse
  • Remove eslint error by renaming the var
  • Test the data a length to avoid JSON.parse headache
  • Use util.isString() over typeof

timemachine3030 and others added 2 commits November 1, 2020 00:42
 - Tests for transformResponse
 - Remove eslint error by renaming the var
 - Test that there data a length to avoid JSON.parse headache
 - Use `util.isString()` over `typeof`
@jasonsaayman jasonsaayman self-assigned this Dec 9, 2020
@jasonsaayman jasonsaayman modified the milestones: v0.21.1, v0.22.0 Dec 9, 2020
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@jasonsaayman jasonsaayman merged commit f2057f7 into axios:master Mar 24, 2021
mbargiel pushed a commit to mbargiel/axios that referenced this pull request Jan 27, 2022
- Tests for transformResponse
 - Remove eslint error by renaming the var
 - Test that there data a length to avoid JSON.parse headache
 - Use `util.isString()` over `typeof`

Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not apply data tansformation to the empty 204 status code responses
2 participants