-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev dependencies #3401
Update dev dependencies #3401
Conversation
- Everything still works as expected. - Remove bundlesize - It still uses libtorb which is deprecated and broken on Win and requires a full suite of build tools on Mac. Keeping it in the package makes it difficult for anyone filing issues to run tests. - See: axios#3396 - Update grunt and it's plugins - Update karma to v4...so much faster! - Changed the karma config. Better changes: axios#3394 - Update Webpack - Uses terser over uglify - Update eslint - Caused an error in util.js from the `global` directive so the directive is removed (it was not needed). - Update typescript - The old version of tsc didn't know about new features in @types/node (like `asserts value`).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice someone is taking care of this! Thank you, also dropped a note about #2536 which I have abandoned at the moment.
"url-search-params": "^0.10.0", | ||
"webpack": "^1.13.1", | ||
"webpack-dev-server": "^1.14.1" | ||
"webpack": "^4.44.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use Webpack 5 since it's out?
ICYMI: took a stab at this in #2536 (and also included removal of superfluous polyfills).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a conflict with the peer dependencies of grunt-webpack. So I rolled back to ^4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timemachine3030 thanks for having a look. My PR got too big, I will probably cut the polyfill removal stuff to a new PR since it can be shipped separately.
Karma and the sauce stuff is cool for e2e testing but I think there may be merit in whittling these down to plain unit tests (can remove many deps and simplify CI/CD). I don't have any concrete ideas yet about how such a switch should be done, or if it may be too much of a risk for losing the real E2E browser scenarios.
- Everything still works as expected. - Remove bundlesize - It still uses libtorb which is deprecated and broken on Win and requires a full suite of build tools on Mac. Keeping it in the package makes it difficult for anyone filing issues to run tests. - See: axios#3396 - Update grunt and it's plugins - Update karma to v4...so much faster! - Changed the karma config. Better changes: axios#3394 - Update Webpack - Uses terser over uglify - Update eslint - Caused an error in util.js from the `global` directive so the directive is removed (it was not needed). - Update typescript - The old version of tsc didn't know about new features in @types/node (like `asserts value`). Co-authored-by: Jay <jasonsaayman@gmail.com>
requires a full suite of build tools on Mac. Keeping it in the
package makes it difficult for anyone filing issues to run tests.
global
directive so thedirective is removed (it was not needed).
@types/node (like
asserts value
).