Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation for the type guard isAxiosError #3767

Merged
merged 3 commits into from May 4, 2021

Conversation

johachi
Copy link
Contributor

@johachi johachi commented Apr 25, 2021

Instructions

  • Adding documentation for the type guard isAxiosError as requested in issue #3732

Both mentioning the type guard and show a short example of how it can be used. The example uses async/await as I felt it was the most natural way.

I recommend merging this at the same time (or after) merging PR #3546 since it fixes the bug isAxiosError(null) // true.

This (#3645) is also a nice PR that would increase confidence in the type guard.

Closes #3732

Copy link
Member

@jasonsaayman jasonsaayman left a comment

👍

@jasonsaayman jasonsaayman merged commit 94fc4ea into axios:master May 4, 2021
1 check passed
@jasonsaayman jasonsaayman added the type:documentation label May 4, 2021
@jasonsaayman jasonsaayman added this to To do in v0.22.0 via automation May 4, 2021
@jasonsaayman jasonsaayman added this to the v0.22.0 milestone May 4, 2021
mbargiel pushed a commit to mbargiel/axios that referenced this issue Jan 27, 2022
Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation
Projects
No open projects
v0.22.0
  
To do
Development

Successfully merging this pull request may close these issues.

2 participants