Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating lib/core/README.md about Dispatching requests #3772

Merged
merged 2 commits into from Apr 30, 2021

Conversation

wafuwafu13
Copy link
Contributor

@wafuwafu13 wafuwafu13 commented Apr 29, 2021

Hi :)
I read code, and supplemented the document.

Copy link
Member

@jasonsaayman jasonsaayman left a comment

Please check out the comment I left.

@@ -3,5 +3,6 @@
The modules found in `core/` should be modules that are specific to the domain logic of axios. These modules would most likely not make sense to be consumed outside of the axios module, as their logic is too specific. Some examples of core modules are:

- Dispatching requests
- requests send at `adapters/` (see lib/adapters/README.md).
Copy link
Member

@jasonsaayman jasonsaayman Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to read:

Requests sent via adapters/ (see lib/adapters/README.md)

Copy link
Contributor Author

@wafuwafu13 wafuwafu13 Apr 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed :) 9e52456

Copy link
Member

@jasonsaayman jasonsaayman left a comment

👍

@jasonsaayman jasonsaayman merged commit a18a0ec into axios:master Apr 30, 2021
1 check passed
mbargiel pushed a commit to mbargiel/axios that referenced this issue Jan 27, 2022
* Updating lib/core/README.md :Dispatching requests

* Fixing expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants