Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parseInt to config.timeout #3781

Merged
merged 2 commits into from May 6, 2021
Merged

Adding parseInt to config.timeout #3781

merged 2 commits into from May 6, 2021

Conversation

@piiih
Copy link
Contributor

@piiih piiih commented May 4, 2021

Issue: #3778

Copy link
Member

@jasonsaayman jasonsaayman left a comment

Please check issues

Loading

lib/adapters/http.js Show resolved Hide resolved
Loading
@@ -29,6 +29,64 @@ describe('supports http with nodejs', function () {
}
});

it('should NOT parse the timeout property', function (done) {
Copy link
Member

@jasonsaayman jasonsaayman May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this test rather be something like should throw an error if the timeout property is not parsable as a number

Loading

Copy link
Contributor Author

@piiih piiih May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! :)

Loading

Copy link
Member

@jasonsaayman jasonsaayman left a comment

👍

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v0.22.0
  
Done
2 participants