-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CI on Github Actions. #3938
Conversation
@jasonsaayman @emilyemorehouse It seems that you are the most active maintainers. Thanks. |
Hi, Thanks I will do, I will be more active again in the weeks to come. |
@jasonsaayman Thanks! I hope that the axios project will move forward. |
@koh110 seems to have passed however I don't see how we are going to handle browser based testing? |
Don't worry, I have answered my own question |
@koh110, thanks very much for making this work, super grateful for your contribution 🥇 |
Hi @koh110 - I think there is a small mistake in the workflow, the matrix defines axios/.github/workflows/ci.yml Line 15 in f3ca637
axios/.github/workflows/ci.yml Lines 19 to 22 in f3ca637
|
@rigor789 could you put in a pull request to fix? |
@jasonsaayman sure, here it is #4069 |
@rigor789 @jasonsaayman Thank you for fixing my bug! I didn't notice it. |
Instructions
Context: #3718 (comment)
Adding CI on Github Actions.
PRs have also stopped CI around June. I think Travis CI needs to be migrated to another domain.
I don't know the CI migration plan for the axios project.
So, I added CI on Github Actions until CI worked again.
Additional context
#3930
#3916