Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI on Github Actions. #3938

Merged
merged 1 commit into from Aug 13, 2021
Merged

Adding CI on Github Actions. #3938

merged 1 commit into from Aug 13, 2021

Conversation

@koh110
Copy link
Contributor

@koh110 koh110 commented Aug 8, 2021

Instructions

Context: #3718 (comment)

Adding CI on Github Actions.

PRs have also stopped CI around June. I think Travis CI needs to be migrated to another domain.
I don't know the CI migration plan for the axios project.
So, I added CI on Github Actions until CI worked again.

Additional context

#3930
#3916

@koh110
Copy link
Contributor Author

@koh110 koh110 commented Aug 13, 2021

@jasonsaayman @emilyemorehouse
Hi! Could you check it please?

It seems that you are the most active maintainers.
If you should ping another maintainer, please let me know.

Thanks.

Loading

@jasonsaayman
Copy link
Member

@jasonsaayman jasonsaayman commented Aug 13, 2021

Hi, Thanks I will do, I will be more active again in the weeks to come.

Loading

@koh110
Copy link
Contributor Author

@koh110 koh110 commented Aug 13, 2021

@jasonsaayman Thanks! I hope that the axios project will move forward.
Please let me know if you have any help.

Loading

@jasonsaayman
Copy link
Member

@jasonsaayman jasonsaayman commented Aug 13, 2021

@koh110 seems to have passed however I don't see how we are going to handle browser based testing?

Loading

@jasonsaayman
Copy link
Member

@jasonsaayman jasonsaayman commented Aug 13, 2021

@koh110 seems to have passed however I don't see how we are going to handle browser based testing?

Don't worry, I have answered my own question

Loading

@jasonsaayman
Copy link
Member

@jasonsaayman jasonsaayman commented Aug 13, 2021

@koh110, thanks very much for making this work, super grateful for your contribution 🥇

Loading

@rigor789
Copy link
Contributor

@rigor789 rigor789 commented Sep 16, 2021

Hi @koh110 - I think there is a small mistake in the workflow, the matrix defines node-version and in setup-node it's reading matrix.node - and I think all 3 builds use the default node version as a result.

node-version: [12.x, 14.x, 16.x]

- name: Setup node
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}

Loading

@jasonsaayman
Copy link
Member

@jasonsaayman jasonsaayman commented Sep 16, 2021

@rigor789 could you put in a pull request to fix?

Loading

@rigor789 rigor789 mentioned this pull request Sep 16, 2021
@rigor789
Copy link
Contributor

@rigor789 rigor789 commented Sep 16, 2021

@jasonsaayman sure, here it is #4069

Loading

@koh110
Copy link
Contributor Author

@koh110 koh110 commented Sep 17, 2021

@rigor789 @jasonsaayman Thank you for fixing my bug! I didn't notice it.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants