Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added errors to be displayed when the query parsing process itself fails. #3961

Merged
merged 6 commits into from Jan 18, 2022

Conversation

djs113
Copy link
Contributor

@djs113 djs113 commented Aug 17, 2021

This PR fixes #3606, the issue is that when there is an error in the query parsing process which happens before request is sent, the error that is displayed is the standard error which doesn't contain much information about the request, so its harder to debug. This PR fixes that problem.

test/unit/adapters/http.js Outdated Show resolved Hide resolved
@djs113
Copy link
Contributor Author

djs113 commented Aug 18, 2021

@jasonsaayman Please approve this workflow.

@jasonsaayman
Copy link
Member

jasonsaayman commented Dec 23, 2021

@djs113 please can you check the failing tests?

@jasonsaayman jasonsaayman reopened this Dec 23, 2021
@jasonsaayman jasonsaayman added the follow-up Issue or pull request requires a follow. label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up Issue or pull request requires a follow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants