Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTTP status code for transformResponse #4580

Merged
merged 10 commits into from May 9, 2022
Merged

Adding HTTP status code for transformResponse #4580

merged 10 commits into from May 9, 2022

Conversation

kaishuu0123
Copy link
Contributor

@kaishuu0123 kaishuu0123 commented Apr 4, 2022

Related Issue

Motivation

  • It would be more useful to get the HTTP status code as well
  • I want to do conditional branching in the transformResponse function using the response status code.

Note

  • Let me know if I'm doing something wrong.

@kaishuu0123
Copy link
Contributor Author

kaishuu0123 commented Apr 27, 2022

Sorry. Removed include changes to dist/ in my pull request.

@jasonsaayman
Copy link
Member

jasonsaayman commented May 3, 2022

@kaishuu0123 can you please add some test cases for this

@jasonsaayman jasonsaayman added follow-up Issue or pull request requires a follow. and removed follow-up Issue or pull request requires a follow. labels May 3, 2022
@kaishuu0123
Copy link
Contributor Author

kaishuu0123 commented May 9, 2022

@jasonsaayman I have added one test case.
The test seems to fail, can you run the test again? (FormData TIMEOUT?)

Chrome Headless 101.0.4951.54 (Linux x86_64) FormData should allow FormData posting FAILED
	Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

@jasonsaayman jasonsaayman removed the follow-up Issue or pull request requires a follow. label May 9, 2022
@jasonsaayman jasonsaayman merged commit 2f50c82 into axios:master May 9, 2022
3 checks passed
@kaishuu0123 kaishuu0123 deleted the adding/status-code-for-transform-response branch May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants