Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Webpack in favor of Rollup. #4596

Merged
merged 4 commits into from May 3, 2022

Conversation

DigitalBrainJS
Copy link
Contributor

@DigitalBrainJS DigitalBrainJS commented Apr 8, 2022

Rollup is better for library bundling. The rollup pipeline generates more compact code. The current minified build loses 2 KB in weight.
It still uses the old Grunt pipeline, but we will be taking small steps.
It is assumed that PR #4594 will be merged since currently client code rely on node.js 'url' module which results in build warnings.

@jasonsaayman
Copy link
Member

jasonsaayman commented Apr 26, 2022

@DigitalBrainJS can you fix the merge conflcits there then i can add this soon

…lup-build

� Conflicts:
�	dist/axios.js
�	dist/axios.map
�	dist/axios.min.js
�	dist/axios.min.map
�	package-lock.json
@jasonsaayman
Copy link
Member

jasonsaayman commented Apr 27, 2022

I will add this to the next version

@jasonsaayman jasonsaayman merged commit fe25630 into axios:master May 3, 2022
3 checks passed
@jafin
Copy link

jafin commented Oct 4, 2022

If Rollup is now the build runner, do you still require https://github.com/axios/axios/blob/v1.x/webpack.config.js to exist in repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants