Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios ES2017 #4787

merged 22 commits into from Jun 18, 2022

Axios ES2017 #4787

merged 22 commits into from Jun 18, 2022


Copy link

@DigitalBrainJS DigitalBrainJS commented Jun 14, 2022

Depends on #4772

  • Refactored sources, Mocha tests, Karma tests to use ES2017 & ESM;
  • Refactored tests structure;
  • Refactored dev scripts;
  • Grunt replaced with Gulp;
  • Webpack replaced with Rollup (for Karma tests);
  • A batch of minor refactorings of the dev environment;


� Conflicts:
�	lib/core/dispatchRequest.js
Refactored accessor building routine;
Refactored default transforms;
Removed `normalizeHeaderName` helper;
Added missed `has` accessor to TS types;
Added progress capturing ability for node.js environment;
Added `maxRate` option to limit the data rate in node.js environment;
Refactored event handled by `onUploadProgress` && `onDownloadProgress` listeners in browser environment;
Added progress & data rate tests for the http adapter;
Added response stream aborting test;
Added a manual progress capture test for the browser;
Updated TS types;
Added TS tests;
Refactored request abort logic for the http adapter;
Added ability to abort the response stream;
� Conflicts:
�	lib/core/transformData.js
�	lib/defaults/index.js
�	lib/helpers/parseHeaders.js
�	lib/utils.js

Added throwing an error if the request stream was silently destroying (without error) Refers to axios#3966;
Replaced grunt with gulp;
Improved dev scripts;
Added Babel for rollup build;
Copy link

jasonsaayman commented Jun 15, 2022

@DigitalBrainJS please can you send me an email with your email address I would like to add you to our slack channel, this pr and another one in the works would make a lot of sense to pull together as one larger refactor. Thanks 😄

package.json Show resolved Hide resolved
@jasonsaayman jasonsaayman merged commit bdf493c into axios:v1.x Jun 18, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants