Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WHATWG URL API instead of url.parse() #4852

Merged
merged 4 commits into from Sep 14, 2022

Conversation

felipedamin
Copy link
Contributor

@felipedamin felipedamin commented Jul 14, 2022

As described by #4022 there are problems when parsing URLs using the deprecated API.

This PR aims to fix this by using the WHATWG URL API. Minor changes were also made because the legacy URL object is not identical to the new one.

The same fix was made to v0.x and v2.x, only waiting to see if there is a request for changes on this PR so I can add them to other versions as well before creating their PRs, mainly because I'd like an opinion about the change made for the "should support sockets" test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants