Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings: SerializerOptions.indexes allows boolean | null | undefined #4862

Merged
merged 2 commits into from Sep 26, 2022

Conversation

gfoidl
Copy link
Contributor

@gfoidl gfoidl commented Jul 18, 2022

SerializerOptions.indexes is typed as indexes?: boolean; but according the docs (ReadMe), PR descriptions and tests (

Promise.all([null, false, true].map(function (mode) {
return axios.postForm('http://localhost:3001/', obj, {formSerializer: {indexes: mode}})
) null is also a valid value.

@meteorlxy
Copy link

meteorlxy commented Aug 2, 2022

Also noticed that. Need to be merged indeed. 👍

@jasonsaayman jasonsaayman merged commit b0710bf into axios:v1.x Sep 26, 2022
7 checks passed
@gfoidl gfoidl deleted the patch-1 branch Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants