Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing of timeout in index.d.ts #4934

Merged
merged 2 commits into from Sep 28, 2022
Merged

Conversation

mrcwbr
Copy link
Contributor

@mrcwbr mrcwbr commented Sep 1, 2022

I was wondering if the timeout in the configuration has to be seconds or milliseconds. I had to dig into the documentation to find the unit.

therefore I introduced a Type Alias in the index.d.ts to improve the interface definition. now you're able to use your IDE to get the unit of the timeout field

Copy link
Member

@jasonsaayman jasonsaayman left a comment

Nice 🏄

@jasonsaayman jasonsaayman merged commit 0959c5c into axios:v1.x Sep 28, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants