Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for AxiosError.from-method #4956

Merged
merged 2 commits into from Dec 1, 2022

Conversation

phloose
Copy link
Contributor

@phloose phloose commented Sep 13, 2022

Adds the method signature for the static method AxiosError.from (https://github.com/axios/axios/blob/v0.x/lib/core/AxiosError.js#L79).

Is there a reason it was not exposed so far?

I am not sure which base branch to choose 馃. As AxiosError.from is also present in the latest 0.x versions would it make more sense to make it the base branch or even main?

@phloose phloose force-pushed the add-missing-axios-error-method branch from f8a8379 to 665db73 Compare September 13, 2022 10:53
@phloose
Copy link
Contributor Author

phloose commented Sep 13, 2022

Sorry, but i don't get your branching strategy 馃槄 Why all theses conflicts? What is the base branch?

@jasonsaayman
Copy link
Member

The base branch is no v1.x, can you please check the conflicts then I will have a look

@phloose
Copy link
Contributor Author

phloose commented Nov 30, 2022

Will do. I dont get why there are so many conflicts for files i didnt touch at all... 馃し鈥嶁檪锔

@phloose phloose force-pushed the add-missing-axios-error-method branch from 7ebce9f to 7e2b109 Compare November 30, 2022 17:44
@phloose
Copy link
Contributor Author

phloose commented Nov 30, 2022

@jasonsaayman conflicts are fixed.

@jasonsaayman jasonsaayman merged commit 6f59cdb into axios:v1.x Dec 1, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants