Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing isArrayLike to allow length as a param. Added test #91

Merged
merged 1 commit into from Jul 23, 2015

Conversation

@instagibb
Copy link
Contributor

commented Jul 21, 2015

Using length as a test for whether an Object is "Array-like" produces unexpected results.

There may be more objects that need specific checks (other than object Arguments). But this passes all existing tests and the new one.

@instagibb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2015

@mzabriskie any thoughts on this? Also when do you see the next version being released?

mzabriskie added a commit that referenced this pull request Jul 23, 2015

Merge pull request #91 from instagibb/master
Fixing isArrayLike to allow length as a param. Added test

@mzabriskie mzabriskie merged commit 183e592 into axios:master Jul 23, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 84.464%
Details
@mzabriskie

This comment has been minimized.

Copy link
Member

commented Jul 23, 2015

Thanks for the PR. I am hoping to get a release in the next few weeks. I'm swamped with a few other projects right now, so just trying to keep all the balls in the air as it were.

@instagibb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2015

No worries. Thanks for the update :)

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Sep 21, 2015

I just released 0.6.0 which includes your PR.

@instagibb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2015

Awesome. Thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.