Fix compiler warnings

Author: axkg

src/tX_audiodevice.cc

@@ -198,10 +198,10 @@ void tX_audiodevice_oss ::play(int16_t* buffer) {
 int tX_audiodevice_alsa ::open() {
     snd_pcm_stream_t stream = SND_PCM_STREAM_PLAYBACK;
     snd_pcm_hw_params_t* hw_params;
-    char pcm_name[64];
+    char pcm_name[4097];
     char* pos;
 
-    strncpy(pcm_name, globals.alsa_device_id, sizeof(pcm_name));
+    strncpy(pcm_name, globals.alsa_device_id, sizeof(pcm_name) - 1);
     if ((pos = strchr(pcm_name, '#')) != NULL)
         *pos = 0;
 

src/tX_audiofile.cc

@@ -32,6 +32,7 @@
 #include "tX_endian.h"
 #include "tX_loaddlg.h"
 #include "wav_file.h"
+#include <cstdint>
 #include <malloc.h>
 #include <string.h>
 
@@ -754,13 +755,14 @@ tX_audio_error tx_audiofile::load_af() {
     }
 
     /* shorten to the actually read size of samples */
-    if (!realloc(data, frames_read * 2)) {
+    int16_t* new_data = (int16_t*)realloc(data, frames_read * 2);
+    if (!new_data) {
         if (data)
             free(data);
         return TX_AUDIO_ERR_ALLOC;
     }
 
-    mem = data;
+    mem = new_data;
     no_samples = frames_read;
 
     return TX_AUDIO_SUCCESS;

src/tX_ladspa.cc

@@ -46,7 +46,7 @@ void LADSPA_Plugin ::init() {
         tX_warning("LADSPA_PATH not set. Trying /usr/lib/ladspa:/usr/local/lib/ladspa");
         strcpy(ladspa_path, "/usr/lib/ladspa:/usr/local/lib/ladspa");
     } else
-        strncpy(ladspa_path, ladspa_path_ptr, sizeof(ladspa_path));
+        strncpy(ladspa_path, ladspa_path_ptr, sizeof(ladspa_path) - 1);
 
     /* Scanning every dir in path */
     start = ladspa_path;

src/tX_maingui.cc

@@ -311,7 +311,7 @@ void load_tt_part(char* buffer) {
 #endif
     turn_audio_off();
 
-    strncpy(globals.tables_filename, buffer, sizeof(globals.tables_filename));
+    strncpy(globals.tables_filename, buffer, sizeof(globals.tables_filename) - 1);
 
     doc = xmlParseFile(buffer);
     if (doc) {

src/tX_vtt.cc

@@ -650,8 +650,6 @@ void vtt_class ::calc_speed() {
 }
 
 void vtt_class ::render_scratch() {
-    int16_t* ptr;
-
     int sample;
 
     d_prec pos_a_f;
@@ -1646,7 +1644,7 @@ void vtt_class ::effect_move(vtt_fx* effect, int pos) {
     if (pos == 0) {
         list->remove(effect);
         list->push_front(effect);
-    } else if (pos == list->size() - 1) {
+    } else if (pos == ((int)list->size()) - 1) {
         list->remove(effect);
         list->push_back(effect);
     } else {

src/tX_vtt.h

@@ -343,10 +343,10 @@ class vtt_class {
     }
 
     int16_t get_sample(int sample) {
-        if (sample >= samples_in_buffer) {
+        if (sample >= (int)samples_in_buffer) {
             if (loop) {
                 // sample %= samples_in_buffer;
-                while (sample >= samples_in_buffer) {
+                while (sample >= (int)samples_in_buffer) {
                     sample -= samples_in_buffer;
                 }
             } else {

src/tX_vttgui.cc

@@ -835,7 +835,6 @@ void build_vtt_gui(vtt_class* vtt) {
     gtk_widget_show(tempbox);
     gtk_box_pack_start(GTK_BOX(tempbox2), tempbox, WID_DYN);
 
-    GtkWidget* pixmap;
     g->audio_minimize = create_top_button(MINIMIZE);
     gtk_box_pack_end(GTK_BOX(tempbox2), g->audio_minimize, WID_FIX);
     gtk_widget_show(g->audio_minimize);