Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SourceFile::new and new_empty #43

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

shadows-withal
Copy link
Contributor

just to separate concerns between a release PR and a feature PR

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably file an issue on test coverage for the source file stuff, but we shouldn't block

@shadows-withal shadows-withal merged commit 7f831b6 into main Apr 27, 2023
@ashleygwilliams ashleygwilliams deleted the feat/simplify-sourcefile branch April 27, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants