feat(executor): add ckb light client system contract #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
changed the title
KaoImin
changed the title
KaoImin
suggested changes
Mar 13, 2023
peterzhb
force-pushed
the
@peter/ckb-light-client
branch
from
34c0882
to
dad8279
Compare
felicityin
reviewed
Mar 14, 2023
core/executor/src/system_contract/ckb_light_client/contract/contracts/CkbLightClient.sol
Outdated
Show resolved
Hide resolved
felicityin
reviewed
Mar 14, 2023
core/executor/src/system_contract/ckb_light_client/contract/contracts/CkbLightClient.sol
Outdated
Show resolved
Hide resolved
felicityin
reviewed
Mar 14, 2023
core/executor/src/system_contract/image_cell/abi/image_cell_abi.json
Outdated
Show resolved
Hide resolved
felicityin
reviewed
Mar 14, 2023
core/executor/src/system_contract/image_cell/contract/yarn.lock
Outdated
Show resolved
Hide resolved
peterzhb
force-pushed
the
@peter/ckb-light-client
branch
3 times, most recently
from
7a7ec3a
to
617bcf8
Compare
KaoImin
previously approved these changes
Mar 14, 2023
|
The branch should be rebase on the top of main branch before merge. |
|
Missing solidity files. |
It will be put in another pr as it is suggested to put all the system contracts' hardhat projects into one under builtin-contract folder. |
peterzhb
force-pushed
the
@peter/ckb-light-client
branch
from
617bcf8
to
bcbb47b
Compare
|
/run-ci |
1 similar comment
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
1 similar comment
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
reviewed
Mar 15, 2023
peterzhb
force-pushed
the
@peter/ckb-light-client
branch
from
bcbb47b
to
2516f1e
Compare
peterzhb
force-pushed
the
@peter/ckb-light-client
branch
from
2516f1e
to
83383b4
Compare
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds ckb light client on Axon to support cross chain functionalities.
Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwcCI Usage
CI Switch