New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add on_start callback #18

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@jcs
Copy link
Contributor

jcs commented Jun 23, 2017

I had a situation where I needed to know if the proxy connection had successfully established, so that a particular fallback situation could occur depending on whether the request had been sent or whether the timeout happened before the connection/negotiation.

A new on_start callback made it easy to accomplish this.

@axsuul

This comment has been minimized.

Copy link
Owner

axsuul commented Jun 23, 2017

Thank you for the pull request!

Sounds like a great addition. Mind if we rename this to on_connect? And can we please update the README.md with the new callback?

👍

@jcs

This comment has been minimized.

Copy link
Contributor Author

jcs commented Jun 23, 2017

Sure, changed to on_connect and added to README.

@axsuul axsuul merged commit 466b552 into axsuul:master Jun 23, 2017

@axsuul

This comment has been minimized.

Copy link
Owner

axsuul commented Jun 23, 2017

@jcs Thanks so much!

I just pushed 0.9.0 to RubyGems and added you to README as a contributor. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment