New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transport and hcomp #539
transport and hcomp #539
Conversation
Codecov Report
@@ Coverage Diff @@
## main #539 +/- ##
============================================
- Coverage 80.54% 79.98% -0.57%
- Complexity 2750 2751 +1
============================================
Files 224 224
Lines 8637 8705 +68
Branches 1071 1072 +1
============================================
+ Hits 6957 6963 +6
- Misses 1097 1159 +62
Partials 583 583
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
db195d5
to
82225ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that we need hfill as primitive? I think it can be implemented in terms of hcomp and cubical subtype
82225ee
to
ba841a7
Compare
1374f68
to
2e7c4ec
Compare
Congratulations!! |
Implement the following primitives:
coe (A: I -> Type) (phi: I): A 0 -> A 1
(need to check the freezing condition)coeFill (A: I -> Type) (phi: I) (u0: A 0) : Path A u (coe A phi u)
coeInv
coeFillInv
forward (A: I -> Type) (r: I) (u: A r): A 1
hcomp {A: Type} {phi: I} (u: I -> Partial phi A) (u0: A): A
(need to check cubical subtypehfill {A: Type} {phi: I} (u: I -> Partial phi A) (u0: A): I -> A
(need to check cubical subtype condition foru0
)comp {phi: I} (A: Type) (u: I -> Partial phi A) (u0: A 0): A 1
(need to check cubical subtype condition foru0
)I will ignore the subtype checks before cubical subtype is implemented in another PR. After cubical subtype is finished we just need to change the signatures and add proper
inS
andoutS
.TODO: explore ways to automatically insert
inS
andoutS
.Update (2022 Oct 23):
coeFill
,coeInv
,coeFillInv
,forward
,hfill
,comp
will not be implemented as primitives. Instead they are helper functionsThis pull request closes #522, #525.