Skip to content
This repository has been archived by the owner on Aug 31, 2018. It is now read-only.

Move non-essential C++ modules into addons? #50

Closed
brodycj opened this issue Sep 12, 2017 · 4 comments
Closed

Move non-essential C++ modules into addons? #50

brodycj opened this issue Sep 12, 2017 · 4 comments

Comments

@brodycj
Copy link
Contributor

brodycj commented Sep 12, 2017

  • Version:
  • Platform:
  • Subsystem:

This would keep the core leaner and safer, though with the risk of increased divergence from "upstream" Node.js (especially with the modules moved out).

@Fishrock123
Copy link
Contributor

Which parts do you see us moving out? I would imagine we'd lean more to adding more (though I am, myself, pretty hesitant about it) - addons can be problematic for many users with less than ideal setups.

Most things are quite important to running node itself, and the community has created me to rely heavily on the parts that aren't. As an example, we could remove zlib but I see more negatives in doing so than positives.

@brodycj
Copy link
Contributor Author

brodycj commented Sep 12, 2017

Especially crypto, HTTP server, TLS may not be useful for all users, especially desktop npm users and Android app embedders.

Or is it better to just start a new project based on V8 and libuv for this and #51?

@addaleax
Copy link
Contributor

Especially crypto, HTTP server, TLS may not be useful for all users, especially desktop npm users and Android app embedders.

npm users use tls extensively, namely for any download via https :) Also, if you really prefer not to have tls available, you can make custom builds using --without-ssl, but very few people use that.

@brodycj
Copy link
Contributor Author

brodycj commented Sep 13, 2017

Thanks guys for the responses to this and #51.

@brodycj brodycj closed this as completed Sep 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants