Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return children views instead of TabAndroid #10

Closed
wants to merge 1 commit into from

Conversation

j-burgos
Copy link
Contributor

Currently, TabAndroid components are being returned instead of the children that should be used by ViewPagerAndroid

Currently, TabAndroid components are being returned instead of the children that should be used by ViewPagerAndroid
@adbayb
Copy link
Owner

adbayb commented Jul 27, 2016

TabAndroid is itself a View component: no need to map a View component since we check that children are only TabAndroid ones so we are sure to only have View children nested inside ViewPagerAndroid.

But, Do you have some unexpected behavior(s) with existing code to explain that pull request ?

@j-burgos
Copy link
Contributor Author

Hi @ayoubdev ,

Nevermind about this pull request, this is related to #13 but I used this approach before digging more into the problem.

@j-burgos j-burgos closed this Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants