Improved texts for applying

app/views/position_applications/create.fragment.slim

@@ -5,6 +5,9 @@
     .item-block
       .item-row
         .notice.success
+          = t('position_applications.application_received')
+          - if show_recommendations?(@call)
+            = t('position_applications.referees_needed', referees_needed: @position_application.call.recommendations_threshold)
           = t('position_applications.edit_by_creating_new_notice')
     .item-block
       .applicant-details

config/locales/en.yml

@@ -50,6 +50,12 @@ en:
   position_applications:
     plural: "Applications"
     admissible_plural: "Admissible"
+    application_received: "We have received your registration."
+    referees_needed:
+      "
+      Please confirm your application by adding %{referees_needed} referees.
+      You will receive a confirmation e-mail with more information on the matter.
+      "
     edit_by_creating_new_notice: "If you want to edit your application, you can submit a new application for the same call for applications. A new application replaces the previous one."
     application_to_be_deleted_notice: "You already have one application in this call for applications. If you submit a new application, the previous one will be deleted. This command cannot be cancelled."
 

config/locales/fi.yml

@@ -59,6 +59,12 @@ fi:
   position_applications:
     plural: "Hakemukset"
     admissible_plural: "Soveltuvat"
+    application_received: "Ilmoittautumisesi on vastaanotettu. "
+    referees_needed:
+      "
+      Vahvista vielä hakemuksesi hankkimalla %{referees_needed} suosittelijaa.
+      Lisätietoja aiheesta saat sähköpostiisi tulevasta vahvistusviestistä.
+      "
     edit_by_creating_new_notice: "Jos haluat muokata hakemustasi, voit jättää uuden hakemuksen samaan hakuun. Uusi hakemus korvaa aiemman."
     application_to_be_deleted_notice: "Sinulla on jo yksi hakemus tähän hakuun. Jos jätät uuden hakemuksen, aiempi poistetaan. Toimintoa ei voi peruuttaa."
     new:

config/locales/sv.yml

@@ -49,6 +49,12 @@ sv:
     error_messages:
        title: "Kan inte spara %{class}"
   position_applications:
+    application_received: "Din anmälning har tagits emot."
+    referees_needed:
+      "
+      Bekräfta den genom att skaffa %{referees_needed} understödjare som stöder din kandidatur.
+      Mera information får du i bekräftelsen som kommer per e-post.
+      "
     edit_by_creating_new_notice: "Om du vill redigera din ansökan kan du lämna in en ny ansökan i samma ansökningsomgång. Den nya ansökan ersätter den gamla."
     application_to_be_deleted_notice: "Du har redan en ansökan i denna ansökningsomgång. Om du lämnar in en ny raderas den gamla. Åtgärden kan inte ångras."
     plural: "Ansökningar"

features/apply_for_position.feature

@@ -75,6 +75,7 @@ Feature: Applying for a position
       | label    | value     |
       | Haen     | Jäseneksi |
       | Oppiarvo | VTT       |
+    And I should see "Vahvista vielä hakemuksesi hankkimalla 3 suosittelijaa"
 
     And I press 'Ok'
     And I should see call for application 'Student council board members'

features/recommend_applications.feature

@@ -41,6 +41,7 @@ Feature: Recommending a position application
     And I should see 0 buttons with text "Aseta"
 
   Scenario: Not seeing a recommend link if the university hasn't enabled recommendations
+    Given "Helsingin yliopisto" has not enabled recommendations
     And I am logged in as a Helsinki university students' union employee
     And I am at front page of 'Helsingin yliopisto'
     And I navigate to home page of call 'Student council board members'

features/step_definitions/organ_steps.rb

@@ -33,3 +33,8 @@
   university = Organization.roots.where(name: uni_name).first
   university.update_attributes(recommendations_threshold: threshold)
 end
+
+Given /^"([^"]*)" has not enabled recommendations$/ do |uni_name|
+  university = Organization.roots.where(name: uni_name).first
+  university.update_attributes(recommendations_threshold: nil)
+end

spec/factories/organizations.rb

@@ -8,6 +8,7 @@
     factory :helsinki_uni do
       name  'Helsingin yliopisto'
       key   'helsinki'
+      recommendations_threshold 3
       _id   '4f6b1edf91bc2b33d3010300'
     end