NSIS installer: Clean up Windows Start Menu entry - #683
Merged
Conversation
OpenSauce04
self-requested a review
March 16, 2025 14:51
OpenSauce04
force-pushed
the
master
branch
2 times, most recently
from
March 18, 2025 12:56
3cbc4a4 to
634ab7c
Compare
Member
|
Does this PR consider people who may be upgrading from an existing install? |
Contributor
Author
|
Oh - it does not. Can add a cleanup for those users and remove it again after a few releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the Windows Start Menu entry by removing the uninstall shortcut (which is ignored and no longer created since at least W10) and by removing the program folder, creating the shortcut directly in the Start Menu. This follows more modern conventions and makes the appearance cleaner (removes the step of needing to expand a folder each time in W10).
UX/UI change in the installer .nsi. File could potentially need some further updates and cleanups, can look at it more in depth later.