Skip to content

externals: Updated externals to avoid CMake 4.0 deprecation errors - #688

Merged
OpenSauce04 merged 1 commit into
azahar-emu:masterfrom
OpenSauce04:cmake4-externals-fix
Mar 17, 2025
Merged

externals: Updated externals to avoid CMake 4.0 deprecation errors#688
OpenSauce04 merged 1 commit into
azahar-emu:masterfrom
OpenSauce04:cmake4-externals-fix

Conversation

@OpenSauce04

Copy link
Copy Markdown
Member

Closes #666

@OpenSauce04 OpenSauce04 added the bug Something isn't working label Mar 16, 2025
@OpenSauce04
OpenSauce04 requested a review from PabloMK7 March 16, 2025 22:02
@OpenSauce04
OpenSauce04 marked this pull request as draft March 16, 2025 22:23
@OpenSauce04
OpenSauce04 force-pushed the cmake4-externals-fix branch from e788416 to 72e41ca Compare March 16, 2025 22:31
@OpenSauce04
OpenSauce04 marked this pull request as ready for review March 17, 2025 16:40

@PabloMK7 PabloMK7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't produce side effects, then lgtm

@OpenSauce04
OpenSauce04 force-pushed the cmake4-externals-fix branch from 72e41ca to 74c9441 Compare March 17, 2025 17:12
@OpenSauce04
OpenSauce04 merged commit eb3aa52 into azahar-emu:master Mar 17, 2025
@OpenSauce04
OpenSauce04 deleted the cmake4-externals-fix branch March 17, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake 4.0 breaks compilation

2 participants