video_core: Fixed emulation window artefacts on OpenGL + Wayland#754
Merged
Merged
Conversation
OpenSauce04
force-pushed
the
wayland-opengl-fix
branch
2 times, most recently
from
42cbabe to
427e51a
Compare
PabloMK7
approved these changes
Mar 21, 2025
PabloMK7
force-pushed
the
wayland-opengl-fix
branch
from
427e51a to
aae110f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where anything that passed over the portion of the emulation window not occupied by the 3DS screens would leave visual artefacts behind:
This PR fixes this by changing the opacity of two
glClearColorcalls from0.0to1.0.On most platforms this value is seemingly ignored and it is displayed as if it was set to
1.0, but on Wayland it respects the value and causes this issue. I'm not sure why they were originally set to that value, there seems to be no benefit to doing so, especially considering that the background colours are set up in the same call, which would be invisible if this was working correctly.