From 128dd4fa8a0ce5c741caaffc7eb18dda2c2e9034 Mon Sep 17 00:00:00 2001
From: Azat Khuzhin <a3at.mail@gmail.com>
Date: Mon, 6 Jul 2020 22:36:16 +0300
Subject: [PATCH] Fix dictGet arguments check during GROUP BY injective
 functions elimination

This patch changes the place where the dictionary will be loaded (during
syntax analysis), but I guess this is fine, it will be loaded anyway.

Fixes: #10342
---
 src/Interpreters/SyntaxAnalyzer.cpp           |  1 +
 ...BY_injective_elimination_dictGet.reference |  1 +
 ...GROUP_BY_injective_elimination_dictGet.sql | 31 +++++++++++++++++++
 3 files changed, 33 insertions(+)
 create mode 100644 tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.reference
 create mode 100644 tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.sql

diff --git a/src/Interpreters/SyntaxAnalyzer.cpp b/src/Interpreters/SyntaxAnalyzer.cpp
index e90b6da3dba9..2e270222c373 100644
--- a/src/Interpreters/SyntaxAnalyzer.cpp
+++ b/src/Interpreters/SyntaxAnalyzer.cpp
@@ -248,6 +248,7 @@ void executeScalarSubqueries(ASTPtr & query, const Context & context, size_t sub
 
 const std::unordered_set<String> possibly_injective_function_names
 {
+        "dictGet",
         "dictGetString",
         "dictGetUInt8",
         "dictGetUInt16",
diff --git a/tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.reference b/tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.reference
new file mode 100644
index 000000000000..9459d4ba2a0d
--- /dev/null
+++ b/tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.reference
@@ -0,0 +1 @@
+1.1
diff --git a/tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.sql b/tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.sql
new file mode 100644
index 000000000000..1c7a4d16f054
--- /dev/null
+++ b/tests/queries/0_stateless/01376_GROUP_BY_injective_elimination_dictGet.sql
@@ -0,0 +1,31 @@
+-- https://github.com/ClickHouse/ClickHouse/issues/11469
+SELECT dictGet('default.countryId', 'country', toUInt64(number)) AS country FROM numbers(2) GROUP BY country; -- { serverError 36; }
+
+
+-- with real dictionary
+DROP TABLE IF EXISTS dictdb_01376.table_for_dict;
+DROP DICTIONARY IF EXISTS dictdb_01376.dict_exists;
+DROP DATABASE IF EXISTS dictdb_01376;
+
+CREATE DATABASE dictdb_01376 ENGINE = Ordinary;
+
+CREATE TABLE dictdb_01376.table_for_dict
+(
+  key_column UInt64,
+  value Float64
+)
+ENGINE = Memory();
+
+INSERT INTO dictdb_01376.table_for_dict VALUES (1, 1.1);
+
+CREATE DICTIONARY IF NOT EXISTS dictdb_01376.dict_exists
+(
+  key_column UInt64,
+  value Float64 DEFAULT 77.77
+)
+PRIMARY KEY key_column
+SOURCE(CLICKHOUSE(HOST 'localhost' PORT 9000 USER 'default' TABLE 'table_for_dict' DB 'dictdb_01376'))
+LIFETIME(1)
+LAYOUT(FLAT());
+
+SELECT dictGet('dictdb_01376.dict_exists', 'value', toUInt64(1)) as val FROM numbers(2) GROUP BY val;