Permalink
Browse files

welcome: use more user-friendly edit summary per WP:WC

WP:WC suggests simply "Welcome!"; this change makes Twinkle use "Welcome to Wikipedia!"
Also removing a pref that is rendered obsolete by this change; and a minor comment fix.
  • Loading branch information...
atlight committed Apr 7, 2012
1 parent 64b6acf commit df8c78523c93c6e8af6b8d0e83469fea71b017c8
Showing with 2 additions and 10 deletions.
  1. +1 −2 modules/friendlywelcome.js
  2. +0 −6 modules/twinkleconfig.js
  3. +1 −2 twinkle.header.js
@@ -661,8 +661,7 @@ Twinkle.welcome.callbacks = {
text += "\n" + welcomeText;
}
var summaryText = "Adding" + ( Twinkle.getFriendlyPref('maskTemplateInSummary') ? '' : ( ' {{[[Template:' + params.value + '|' + params.value + ']]}}' ) ) +
" welcome template.";
var summaryText = "Welcome to Wikipedia!";
pageobj.setPageText(text);
pageobj.setEditSummary(summaryText + Twinkle.getPref('summaryAd'));
pageobj.setWatchlist(Twinkle.getFriendlyPref('watchWelcomes'));
@@ -603,12 +603,6 @@ Twinkle.config.sections = [
helptip: "Some welcome templates have an opening sentence like \"Hi, I'm <username>. Welcome\" etc. If you turn off this option, these templates will not display your username in that way.",
type: "boolean"
},
{
name: "maskTemplateInSummary",
label: "Omit the name of the welcome template in the edit summary",
helptip: "The names of some of the templates (e.g. \"welcome-anon-vandal\") may be viewed by the user as attacks, so it is better to leave them out of the edit summary",
type: "boolean"
},
{
name: "quickWelcomeMode",
label: "Clicking the \"welcome\" link on a diff page will",
@@ -132,7 +132,6 @@ Twinkle.defaultConfig.friendly = {
insertUsername: true,
quickWelcomeMode: "norm",
quickWelcomeTemplate: "welcome",
maskTemplateInSummary: true,
customWelcomeList: [],
// Talkback
markTalkbackAsMinor: true,
@@ -311,5 +310,5 @@ function twAddPortletLink( task, text, id, tooltip )
return link;
}
// check if account is experienced enough for more advanced functions
// check if account is experienced enough to use Twinkle
var twinkleUserAuthorized = userIsInGroup( 'autoconfirmed' ) || userIsInGroup( 'confirmed' );

0 comments on commit df8c785

Please sign in to comment.