New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues needing to be fixed for deli #1

Closed
azatoth opened this Issue May 22, 2011 · 5 comments

Comments

Projects
None yet
3 participants
@azatoth
Owner

azatoth commented May 22, 2011

  • Make sure image is deleted before unlinking
  • hide "invalid token" the first times
@Ebe123

This comment has been minimized.

Contributor

Ebe123 commented May 29, 2011

Logging is not working (tried 2 times).

@atlight

This comment has been minimized.

Collaborator

atlight commented Jun 8, 2011

This issue is actually about the image batch deletion tool for admins, but anyway... I'll add DI logging.

@atlight

This comment has been minimized.

Collaborator

atlight commented Mar 30, 2013

In fact, deli should be merged with batchdelete, since the process with API of deleting a file and an image are now the same.

atlight added a commit that referenced this issue Jul 2, 2014

delimages: User notification to prepare for impending merge
I want to merge this with batchdelete, per issue #1.

atlight added a commit that referenced this issue Jul 3, 2014

batchdelete: Further improvements
- No need for it to be enabled on non-existent pages
- Don't unlink/delete redirects if the page wasn't successfully deleted
  (see issue #1 - same issue but in delimages)

atlight added a commit that referenced this issue Jul 3, 2014

delimages: User notification to prepare for impending merge
I want to merge this with batchdelete, per issue #1.

atlight added a commit that referenced this issue Jun 9, 2015

batchdelete: Further improvements
- No need for it to be enabled on non-existent pages
- Don't unlink/delete redirects if the page wasn't successfully deleted
  (see issue #1 - same issue but in delimages)
@atlight

This comment has been minimized.

Collaborator

atlight commented Jun 9, 2015

The plan from 30 March 2013 has finally come to fruition in 315c06b. (Things don't happen quickly around here!)

If no-one objects in the next few months, I plan to delete the delimages module altogether.

@azatoth's original concerns from 2011 should now both be fixed. Leaving this issue open, though, to track the removal of delimages.

@atlight

This comment has been minimized.

Collaborator

atlight commented Nov 19, 2015

@atlight atlight closed this Nov 19, 2015

Siddhartha-Ghai added a commit to Siddhartha-Ghai/twinkle that referenced this issue Aug 2, 2018

delimages: User notification to prepare for impending merge
I want to merge this with batchdelete, per issue azatoth#1.

Siddhartha-Ghai added a commit to Siddhartha-Ghai/twinkle that referenced this issue Aug 3, 2018

batchdelete: Further improvements
- No need for it to be enabled on non-existent pages
- Don't unlink/delete redirects if the page wasn't successfully deleted
  (see issue azatoth#1 - same issue but in delimages)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment