Rollback should report error when revision trips the spam blacklist #138

Closed
logological opened this Issue Jan 16, 2013 · 3 comments

Comments

Projects
None yet
3 participants

If you use Twinkle to roll back one or more edits to a previous version of a page which contains an external link to a URL on the MediaWiki spam blacklist, then Twinkle will falsely report that the rollback was successful.

Steps to reproduce:

  1. Create a page [[foo]] which contains a link to http://www.example.com.
  2. Add \bexample.com\b to [[MediaWiki:Spam-blacklist]].
  3. Edit [[foo]] to remove the link to http://www.example.com.
  4. Use Twinkle to roll back the edit to [[foo]].

Observed behaviour:

Twinkle reports, "Grabbing data of earlier revisions: done. Reversion completed: completed" and then redirects to the current version of the page. The reversion is not effected, though depending on how different the two revisions are, this may not be obvious to the user.

Expected behaviour:

Twinkle should conspicuously complain to the user that it cannot roll back to the requested revision because that revision has tripped the MediaWiki spam blacklist.

Collaborator

atlight commented Jan 22, 2013

I might have to apply for adminship on testwiki to play with this.

Owner

azatoth commented Jan 22, 2013

Fixed!
On 22 Jan 2013 02:12, "This, that and the other" notifications@github.com
wrote:

I might have to apply for adminship on testwiki to play with this.


Reply to this email directly or view it on GitHub.

Collaborator

atlight commented Jan 24, 2013

Thanks Aza!!

Fixed in 3299354

atlight closed this Jan 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment