Skip to content

Rolling back IPv6 addresses does not work correctly #145

Closed
Krenair opened this Issue Mar 8, 2013 · 1 comment

2 participants

@Krenair
Krenair commented Mar 8, 2013

From https://bugzilla.wikimedia.org/show_bug.cgi?id=45901 :

http://en.wikipedia.org/w/index.php?title=Electronica&diff=542828286&oldid=540998447
a user rolled back an IPv6 address who made two edits in a row, but the
rollback feature only reverted one of them. The feature seems to work normally
in other situations.

@atlight atlight added a commit that closed this issue May 31, 2014
@atlight atlight fluff: Make rollback of IPv6 addresses work properly
MediaWiki has two conventions for IPv6 addresses: sanitized and
prettified. The prettified form is only used when generating a user
link, i.e. "User (talk | contribs | block)"; everywhere else, you get
the sanitized form. This meant that the textual comparison of IPv6
addresses wasn't working, and multiple edits by the same IP address were
not all rolled back.
See also MediaWiki bug 44161.
Fixes #145.
33530b1
@atlight atlight closed this in 33530b1 May 31, 2014
@Siddhartha-Ghai Siddhartha-Ghai added a commit to Siddhartha-Ghai/twinkle that referenced this issue Feb 21, 2015
@atlight atlight fluff: Make rollback of IPv6 addresses work properly
MediaWiki has two conventions for IPv6 addresses: sanitized and
prettified. The prettified form is only used when generating a user
link, i.e. "User (talk | contribs | block)"; everywhere else, you get
the sanitized form. This meant that the textual comparison of IPv6
addresses wasn't working, and multiple edits by the same IP address were
not all rolled back.
See also MediaWiki bug 44161.
Fixes #145.
e32e410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.