New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle abuse filter warnings/errors #182

Open
Amalthea opened this Issue Oct 7, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@Amalthea
Collaborator

Amalthea commented Oct 7, 2013

An abuse filter warning is currently an irrecoverable error. API will return something like:

<?xml version="1.0"?><api><edit code="abusefilter-warning-codespill" info="Hit AbuseFilter: Extraneous formatting" warning="&lt;table [...]" result="Failure" /></api>

(warning HTML truncated).

I imagine Twinkle should display that warning and allow the user to try again (not sure what the mechanism for that is)

@ghost ghost assigned atlight Oct 8, 2013

@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Oct 8, 2013

Collaborator

Hmm, I'll have a play with this.

Collaborator

atlight commented Oct 8, 2013

Hmm, I'll have a play with this.

@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight
Collaborator

atlight commented Oct 12, 2013

atlight added a commit that referenced this issue Oct 20, 2013

morebits: add primitive AbuseFilter handling
This only handles the "warn" and "disallow" AbuseFilter actions. It
really needs improvement per the comment on line 2362.
Per issue #182.
@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Oct 20, 2013

Collaborator

The only problem with that commit is that all is lost when an AbuseFilter warning is hit. The edit should be retried automatically (as happens for edit conflicts) if the editor chooses to retry. The problem lies in providing the choice to the user. I seem to remember that AzaToth is quite keen to see the Status system overhauled, and some kind of status-based prompt could be implemented as part of any such future overhaul.

Collaborator

atlight commented Oct 20, 2013

The only problem with that commit is that all is lost when an AbuseFilter warning is hit. The edit should be retried automatically (as happens for edit conflicts) if the editor chooses to retry. The problem lies in providing the choice to the user. I seem to remember that AzaToth is quite keen to see the Status system overhauled, and some kind of status-based prompt could be implemented as part of any such future overhaul.

@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Oct 21, 2013

Collaborator

Unassigning myself for now, as I don't plan to do any more work on this for the time being.

Collaborator

atlight commented Oct 21, 2013

Unassigning myself for now, as I don't plan to do any more work on this for the time being.

Siddhartha-Ghai added a commit to Siddhartha-Ghai/twinkle that referenced this issue Jul 29, 2014

morebits: add primitive AbuseFilter handling
This only handles the "warn" and "disallow" AbuseFilter actions. It
really needs improvement per the comment on line 2362.
Per issue azatoth#182.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment