Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Include expiry parameter when applying protection tags as a non-admin #202

Open
atlight opened this Issue · 3 comments

2 participants

@atlight
Collaborator

From WT:TW:

With the admin protection interface, would it be possible for Twinkle to automatically include the expiry parameter when the interface is being used to protect the page? Thanks, Callanecc (talk • contribs • logs) 08:00, 3 December 2013 (UTC)

@Callanecc: Could you elaborate a bit here? I'm not quite sure what you're referring to. Do you mean the |expiry= parameter on the protection tags? — This, that and the other (talk) 05:04, 6 December 2013 (UTC)

Sorry, yep that's what I was referring to. Callanecc (talk • contribs • logs) 06:12, 6 December 2013 (UTC)

I suppose it's a matter of looking at wgRestrictionEdit in mw.config, if applying a protection tag to an already-protected page, or else looking at the new protection being applied by Twinkle.

@atlight
Collaborator

Admis get this, it just needs to be implemented for lusers like me.

@Callanecc

At the moment it doesn't happen for admins when applying pending changes can it be added in there as well please?

@atlight
Collaborator

At the moment it doesn't happen for admins when applying pending changes can it be added in there as well please?

Done this one. But the real topic of this issue remains.

Turns out we can't use wgRestrictionEdit as it just gives the user group restrictions, not their expiry. Looks like we'll have to ask the API when the user submits their request.

@atlight atlight was assigned
@atlight atlight changed the title from Include expiry parameter when applying protection tags to Include expiry parameter when applying protection tags as a non-admin
@Siddhartha-Ghai Siddhartha-Ghai referenced this issue from a commit in Siddhartha-Ghai/twinkle
@atlight atlight protect: Make tag expiry work for Pending Changes protection
Related to issue #202.
ec91553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.