New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include expiry parameter when applying protection tags as a non-admin #202

Open
atlight opened this Issue Dec 27, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@atlight
Collaborator

atlight commented Dec 27, 2013

From WT:TW:

With the admin protection interface, would it be possible for Twinkle to automatically include the expiry parameter when the interface is being used to protect the page? Thanks, Callanecc (talk • contribs • logs) 08:00, 3 December 2013 (UTC)

@Callanecc: Could you elaborate a bit here? I'm not quite sure what you're referring to. Do you mean the |expiry= parameter on the protection tags? — This, that and the other (talk) 05:04, 6 December 2013 (UTC)

Sorry, yep that's what I was referring to. Callanecc (talk • contribs • logs) 06:12, 6 December 2013 (UTC)

I suppose it's a matter of looking at wgRestrictionEdit in mw.config, if applying a protection tag to an already-protected page, or else looking at the new protection being applied by Twinkle.

@atlight

This comment has been minimized.

Collaborator

atlight commented Jan 27, 2014

Admis get this, it just needs to be implemented for lusers like me.

@Callanecc

This comment has been minimized.

Callanecc commented Jan 30, 2014

At the moment it doesn't happen for admins when applying pending changes can it be added in there as well please?

atlight added a commit that referenced this issue Feb 1, 2014

@atlight

This comment has been minimized.

Collaborator

atlight commented Feb 1, 2014

At the moment it doesn't happen for admins when applying pending changes can it be added in there as well please?

Done this one. But the real topic of this issue remains.

Turns out we can't use wgRestrictionEdit as it just gives the user group restrictions, not their expiry. Looks like we'll have to ask the API when the user submits their request.

@ghost ghost assigned atlight Feb 1, 2014

@atlight atlight changed the title from Include expiry parameter when applying protection tags to Include expiry parameter when applying protection tags as a non-admin May 31, 2014

Siddhartha-Ghai added a commit to Siddhartha-Ghai/twinkle that referenced this issue Feb 21, 2015

@atlight atlight removed their assignment Nov 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment